This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Utilize Polars.DataFrame for performance in ModelbitComponent #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ykeremy
commented
Oct 4, 2023
•
ykeremy
commented
- Does this PR have impact on local development experience? If yes, make sure you have a plan and add the documentations to address issues that come with the change
- bump version
- make a release
- publish to pypi service
wintonzheng
reviewed
Oct 4, 2023
wintonzheng
reviewed
Oct 4, 2023
wintonzheng
reviewed
Oct 4, 2023
|
❤️ I love the implementation. got the question about the composite identifier tho |
wintonzheng
reviewed
Oct 10, 2023
wintonzheng
reviewed
Oct 10, 2023
suchintan
reviewed
Oct 12, 2023
suchintan
reviewed
Oct 12, 2023
suchintan
reviewed
Oct 12, 2023
| ) | ||
| df = df.filter(pl.col(feature_name).is_not_null()) | ||
| if len(df) > 1: | ||
| raise WyvernFeatureValueError( |
There was a problem hiding this comment.
Can we add a log line here / reason here?
suchintan
reviewed
Oct 12, 2023
suchintan
approved these changes
Oct 12, 2023
wintonzheng
approved these changes
Oct 13, 2023
suchintan
reviewed
Oct 14, 2023
| A DataFrame that contains all the real-time features. | ||
| """ | ||
| grouped_features = defaultdict(list) | ||
| for key, value in real_time_feature_dfs: |
There was a problem hiding this comment.
Should this be a dict comprehension?
There was a problem hiding this comment.
Good question.
I don't think we can just do a dict comprehension because we're appending to a list since it's acceptable to have collisions.
However, n isn't necessarily a small number either. I'd say let's just see how this performs first. I believe the ideal upgrade here might be changing how the real time features are calculated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.